fix: skip selector keyboard on windows#3286
Merged
Merged
Conversation
Avoid crossterm's unsupported keyboard progressive enhancement path on Windows while preserving the selector's normal input handling. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
NasroelLah
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Windows selector startup failure by skipping crossterm keyboard progressive enhancement on Windows while preserving normal selector input handling.
Context
Fixes #3285.
The selector currently pushes
KeyboardEnhancementFlags::DISAMBIGUATE_ESCAPE_CODESduring terminal setup. On Windows, crossterm can route that command through the legacy Windows API path for stderr, where keyboard progressive enhancement is unsupported and fails before the selector can render.Changes
Key Implementation Details
Windows now returns
falsefrom the keyboard enhancement setup helper, so teardown skipsPopKeyboardEnhancementFlags. Non-Windows platforms continue to usePushKeyboardEnhancementFlags(KeyboardEnhancementFlags::DISAMBIGUATE_ESCAPE_CODES)as before.Use Cases
Testing
Links