feat: retry the last user event#3373
Closed
Frozair wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this out because the linked issue was already closed before submission, so I’m not planning to spend more review/follow-up time on this lane. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API::retry(conversation_id)path instead of routing/retrythrough an empty follow-up messageforge_mainto the new API method and add focused regression tests for retry event extractionWhy
The current interactive retry flow is reachable, but it retries by sending an empty follow-up into the conversation. This PR keeps
/retrytied to the last actual user event, which is a closer semantic match for a real retry and avoids depending on a synthetic empty message.Verification
cargo test -p forge_domain test_last_retryable_eventcargo test -p forge_main retrycargo check -p forge_api -p forge_maingit diff --check/claim #389