Skip to content

Conversation

mocchira
Copy link
Contributor

This PR makes request_builder_hook configurable for https://github.com/tailor-inc/platform-core-services/issues/8902

@mocchira mocchira self-assigned this Aug 18, 2025
@mocchira mocchira requested a review from Copilot August 18, 2025 05:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the request_builder_hook configurable by enabling it to be passed through from WebOptions to the deno_fetch extension, addressing the TODO comment that previously indicated it wasn't being used.

  • Changes the error type from deno_core::error::AnyError to deno_error::JsErrorBox in hook signatures
  • Removes the TODO comment and enables the request_builder_hook to be passed from WebOptions to deno_fetch
  • Updates import statements to use the new error type

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/runtime_builder.rs Updates the hook parameter type in with_web_request_builder_hook method
src/ext/web/options.rs Changes the error type in WebOptions struct and updates imports
src/ext/web/mod.rs Enables the request_builder_hook to be passed through to deno_fetch instead of being hardcoded to None

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link

@remiposo remiposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants