Skip to content

Refactor badge value normalization to remove nested ternary lint violations#289

Merged
IzumiSy merged 4 commits into
mainfrom
copilot/fix-lint-errors
May 26, 2026
Merged

Refactor badge value normalization to remove nested ternary lint violations#289
IzumiSy merged 4 commits into
mainfrom
copilot/fix-lint-errors

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 26, 2026

  • Review new @copilot feedback and confirm required refactor scope
  • Move duplicated toValueArray logic into shared helper in badge-list module
  • Update DataTable and DescriptionCard badge renderers to reuse shared helper
  • Validate with targeted lint/tests for affected components
  • Run CodeQL check and push commit
  • Reply to new PR comment with commit hash

@IzumiSy
Copy link
Copy Markdown
Contributor

IzumiSy commented May 26, 2026

@copilot can you avoid using let and create a seperated function instead?

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 26, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@tailor-platform/app-shell@289
npm i https://pkg.pr.new/@tailor-platform/app-shell-sdk-plugin@289
npm i https://pkg.pr.new/@tailor-platform/app-shell-vite-plugin@289

commit: d699326

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 26, 2026

@copilot can you avoid using let and create a seperated function instead?

Updated in e5018b0. I replaced the let-based normalization with a dedicated toValueArray helper function in both affected files and kept behavior unchanged.

Copilot AI requested a review from IzumiSy May 26, 2026 02:56
@IzumiSy IzumiSy marked this pull request as ready for review May 26, 2026 03:03
Comment thread packages/core/src/components/data-table/cell-renderers.tsx Outdated
Copilot AI requested a review from IzumiSy May 26, 2026 03:10
@IzumiSy IzumiSy merged commit 7201d21 into main May 26, 2026
5 checks passed
@IzumiSy IzumiSy deleted the copilot/fix-lint-errors branch May 26, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants