feat: support query via GET#47
Merged
Merged
Conversation
Instead of separate methods like `QueryViaGet()` and `QueryViaGetWithVariables()`, introduce `TestWithMethod(t, method)` to specify the HTTP method at test start. This simplifies the API: - Before: `checker.Test(t).QueryViaGet(q)` - After: `checker.TestWithMethod(t, http.MethodGet).Query(q)`
Contributor
Author
|
@ikawaha |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Added support for GraphQL queries via GET requests, following the GraphQL over HTTP specification.
New APIs
TestWithMethod(t TestingT, method string)- Start a new test with a specified HTTP methodWHY
The GraphQL over HTTP specification supports the use of GET method for query operations.
GET requests for queries are useful in the following scenarios:
This PR enables gqlcheck to test GraphQL servers that use GET transport.