Skip to content

fix: setup ci#49

Merged
k1LoW merged 2 commits into
mainfrom
bump-up-go
Dec 23, 2025
Merged

fix: setup ci#49
k1LoW merged 2 commits into
mainfrom
bump-up-go

Conversation

@k1LoW
Copy link
Copy Markdown
Contributor

@k1LoW k1LoW commented Dec 23, 2025 •
edited
Loading

WHAT

  • Update Go directive version from 1.23.0 to 1.24
  • Add tests for testdata/gqlgen-todos directory in CI workflow (.github/workflows/go.yml)
  • Clean up Makefile

WHY

  • Go 1.24 is the current oldstable version, and this aligns with the go directive in testdata/gqlgen-todos
    • And allows easy installation of gocredits via go install
  • The Go module under testdata/gqlgen-todos was not being tested in CI
  • Simplify Makefile to ensure consistent test execution between local and CI environments

@k1LoW k1LoW self-assigned this Dec 23, 2025
@k1LoW k1LoW marked this pull request as ready for review December 23, 2025 01:50
@k1LoW k1LoW requested a review from a team as a code owner December 23, 2025 01:50
dragon3
dragon3 approved these changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dragon3 dragon3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@k1LoW k1LoW merged commit e2ef662 into main Dec 23, 2025
2 checks passed
@k1LoW k1LoW deleted the bump-up-go branch December 23, 2025 01:52
@github-actions github-actions Bot mentioned this pull request Dec 23, 2025
Merged
@k1LoW k1LoW added the Type: House Keeping Code style updates, fix typo, etc. label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dragon3 dragon3 dragon3 approved these changes

Assignees

@k1LoW k1LoW

Labels

Type: House Keeping Code style updates, fix typo, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@k1LoW @dragon3