android: skip SAF directory picker if unsupported #676
+71
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates tailscale/corp#30254 This adds an upfront isAndroidTV check before we set the SAF directory picker activity. We'll check both that we can actually launch the activity and that this isn't and AndroidTV device where the directory picker activity isn't supported or has a tendency to throw ActivityNotFound exceptions. Signed-off-by: Jonathan Nobels <[email protected]>
barnstar
force-pushed
the
jonathan/tv-dirsel
branch
from
cd7b702 to
aa8f16b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tailscale/corp#30254
This adds an upfront isAndroidTV check before we setup the SAF directory picker activity. We'll check both that the activity can be launched and that this isn't and AndroidTV device otherwise, we'll leave the activity launcher unset.
@kari-ts This may be redundant with the other SAF fixes in the pipe (or it may need to be worked into those). Close it if so.