ts_noise: factor out Noise implementation#186
Open
danderson wants to merge 3 commits into
Open
Conversation
danderson
force-pushed
the
push-tqznrnywrrvw
branch
2 times, most recently
from
300531e to
2ffc9ba
Compare
danderson
force-pushed
the
push-tqznrnywrrvw
branch
from
2ffc9ba to
b62ef30
Compare
Also switch to use aws-lc-rs. We already have to pull in aws-lc-rs for rustls, so avoid using rustcrypto as well for binary size. Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I690c8c138843750e0486ff9b1cf36df26a6a6964
Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: Id81c21d18d19205b249d89d477a3d9a96a6a6964
Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: Iffa6cb966097979b738ae22a946ac2aa6a6a6964
danderson
force-pushed
the
push-tqznrnywrrvw
branch
from
b62ef30 to
c056f38
Compare
Member
Author
|
I think this is ready. There's probably some cleanups possible in how ts_tunnel and ts_control_noise use the common noise impls, but this was the minimally-ish invasive change needed to make the refactor happen. All tests pass of course, and also verified that examples/tcp_echo still works from a tailscale-go peer, which gives a proof that both the control protocol and wireguard work sufficiently to enable communication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enable both ts_tunnel and ts_control_noise to use the same underlying crypto primitives when possible.