This repository was archived by the owner on Dec 18, 2021. It is now read-only.
Fix bug in Windows Maven Wrapper script - #179
Open
baincd wants to merge 1 commit into
Open
Conversation
|
I will integrate this and likely do a release, as the version at Apache is currently unusable for 3.x users and will continue to be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I am aware that this project is frozen. However, this version of maven wrapper is still very common, including in new projects generated by Spring Initializr. Therefore, I request this be kept open as documentation for others on how to resolve this issue.)
The
mvnw.cmdscript that has a bug in the functionality that should loop over the.mvn/wrapper/maven-wrapper.properties, which causes the properties to not take effect. This is especially problematic in development environments that require the use of a maven repository other than Maven Central.To fix the issue, in mvnw.cmd edit the FOR loop at lines 125-127 to add the
usebackqoptionExplanation: The double quotes around the filename causes the FOR command to treat it as string. But adding the
usebackqoption changes the FOR command to instead treat the double-quoted string as a filename set (reference)