Open
Conversation
hiromon0125
requested changes
Feb 12, 2026
Contributor
hiromon0125
left a comment
hiromon0125
left a comment
There was a problem hiding this comment.
A few problems with the actual code, but we might also refactor the affected area, so we are going to hold off on merging this.
| camera = conf["camera_index"] if camera is None else camera | ||
| vid_conn = self.tracker.add_capture(hostname, camera) | ||
| conn = Connection(hostname, port or conf["socket_port"], vid_conn) | ||
| conn = Connection(hostname, port or conf["socket_port"], vid_conn, conf["tracking_priority"]) |
Contributor
There was a problem hiding this comment.
Suggested change
| conn = Connection(hostname, port or conf["socket_port"], vid_conn, conf["tracking_priority"]) | |
| conn = Connection(hostname, port or conf["socket_port"], vid_conn, conf.get("tracking_priority", "largest") |
|
|
||
|
|
||
| def calculate_center_bbox(bbox: tuple[int, int, int, int]): | ||
| def calculate_center_bbox(bbox: list[int]): |
| ) | ||
|
|
||
| self._bboxes = bboxes_by_host | ||
| # culled_bboxes: dict[str, ] = self.cull_bboxes(bboxes_by_host) |
Contributor
There was a problem hiding this comment.
delete commented out code
| # Class for handling video feed and object detection model usage | ||
| class Tracker: | ||
| speaker_bbox: tuple[int, int, int, int] | None = None | ||
| speaker_bbox: list[int] | None = None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the the ability to track the smallest and the largest detected bounding box. Which one to prioritize when multiple bounding boxes are in the frame can be determined by setting the 'tracking_priority' variable in config. Closes issue #178
Metrics