Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-customize clippy #185

Closed
wants to merge 2 commits into from
Closed

Un-customize clippy #185

wants to merge 2 commits into from

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jan 29, 2025

I'd rather enable specific useful lints down the line.

The pedantic group is rather.. pedantic.
I'd rather enable specific useful lints down the line.
@jplatte jplatte requested a review from JakkuSakura January 29, 2025 10:26
@tamasfe
Copy link
Owner

tamasfe commented Jan 29, 2025

I'd rather enable specific useful lints down the line.

I don't agree with this, clippy has hundreds of rules with new ones being added over time. Enabling only specific lints means that you are aware of all the rules and know exactly which ones you will find useful. Disabling a rule because it is not useful for us is much better than not being aware of potentially useful rules at all. I've found that clippy's pedantic lint group is mostly spot on with some debatable exceptions.

@jplatte
Copy link
Collaborator Author

jplatte commented Jan 29, 2025

Yes, clippy has lots of lints but this does not disable all of them. Most of its lints are in one of the warn-by-default groups (AFAICT: cargo, complexity, correctness, perf, style, suspicious).

If you still would like to keep the existing thing, I guess I'll just extend the #[allow] list as part of my next PR where I found one of the pedantic lints to be unhelpful though 🤷🏼

@tamasfe
Copy link
Owner

tamasfe commented Jan 29, 2025

If you still would like to keep the existing thing

I'd prefer that, yes. I believe that the pedantic group has a lot more useful lints than not useful ones, but of course I'm open for discussion if you disagree with this.

@jplatte jplatte closed this Feb 1, 2025
@jplatte jplatte deleted the jplatte/clippy branch February 1, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants