Enable task farming for falcon and isambard3#234
Open
GaryLZW wants to merge 19 commits intotamm-cci:mainfrom
Open
Enable task farming for falcon and isambard3#234GaryLZW wants to merge 19 commits intotamm-cci:mainfrom
GaryLZW wants to merge 19 commits intotamm-cci:mainfrom
Conversation
Collaborator
…into task_farming_falcon update to main branch updates
This reverts commit f319dad. This does not do what I wanted.
…ient and SocketIOcalculator; trying a new test
…into task_farming_falcon Updating my local branch
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
I have used this for a while and didn't run into bugs, so I think it is okay to merge now. Somehow the CI test still try Python 3.7 and 3.8 though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first attempt to make task farming work on falcon and isambard3, as discussed here #231.
These code passed a simple test case I used, but more testing may be needed.
Major changes are listed here.
cwdis required.srunon falcon to enable task farming. Manually addingexport I_MPI_PMI_LIBRARY=/usr/lib64/libpmi.soto submission script is required though.Note on the memory arguments for task farming on falcon:
I tested adding this
--mem=$SLURM_MEM_PER_NODEto the cpu commands, and it fails with "invaild --mem argument" error.Letting Slurm quietly bind cpu to memory before task runs (default behaviour) worked for my test.