Open
Conversation
gyamada619
requested changes
Oct 17, 2022
Contributor
gyamada619
left a comment
gyamada619
left a comment
There was a problem hiding this comment.
So this thing - I'm a little apprehensive about "CLAG1" type entries, for example. That introduces complexity that isn't inherent to the upstream source.
Collaborator
Author
|
I agree the CLAG1 was just a placeholder but in order to be a valid key it needs to be unique |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring JSON to be more machine readable.
@gyamada619 Let me know your thoughts on the subunits where the code is the same as the parent unit. Currently they are assigned as CODE1 or CODE2.