Skip to content

fix: use BigDecimal to decode decimal in mysql #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tandemdude merged 1 commit into from
Jul 10, 2025
Merged

fix: use BigDecimal to decode decimal in mysql #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/sqltypes/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package sqltypes

import (
"fmt"

"github.com/sqlc-dev/plugin-sdk-go/plugin"
"github.com/sqlc-dev/plugin-sdk-go/sdk"
)
Expand All @@ -20,9 +21,8 @@ func MysqlTypeToJavaType(identifier *plugin.Identifier) (string, error) {
return "byte[]", nil
case "double", "double precision", "real":
return "Double", nil
// TODO - why does gen-kotlin use string for this? look into a better solution
case "decimal", "dec", "fixed":
return "String", nil
return "java.math.BigDecimal", nil
case "date":
return "java.time.LocalDate", nil
case "datetime", "time":
Expand Down
Loading