Feature/query parameter limit #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for your PR! I'll give it a test once I'm home from work. |
davfsa
suggested changes
Oct 9, 2025
Contributor
davfsa
left a comment
davfsa
left a comment
There was a problem hiding this comment.
Hey!
Thanks for your PR and sorry it took so long for it to be reviewed. I gave it a try and found that its not actually functional. It will generate the model correctly, but it doesn't properly build the statement.
Note the lack of stmt.setXXX calls
Author
|
@tandemdude I’ve implemented the requested changes. Could you please review them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for query_parameter_limit configuration option
This PR implements support for the query_parameter_limit configuration option, which enables automatic generation of a data model as method input when the number of query parameters exceeds the specified limit.