Skip to content

fix: remove unsafe exec() in checkPackageRuning.py#35169

Open
orbisai0security wants to merge 1 commit into
taosdata:mainfrom
orbisai0security:fix-fix-v-005-shell-injection-checkpackageruning
Open

fix: remove unsafe exec() in checkPackageRuning.py#35169
orbisai0security wants to merge 1 commit into
taosdata:mainfrom
orbisai0security:fix-fix-v-005-shell-injection-checkpackageruning

Conversation

@orbisai0security
Copy link
Copy Markdown
Contributor

Summary

Fix critical severity security issue in packaging/checkPackageRuning.py.

Vulnerability

Field Value
ID V-005
Severity CRITICAL
Scanner multi_agent_ai
Rule V-005
File packaging/checkPackageRuning.py:50

Description: The packaging script constructs OS shell commands by directly interpolating the serverHost variable using Python % string formatting without any sanitization or validation. An attacker who can control the serverHost value (via command-line argument, environment variable, or configuration file) can inject shell metacharacters to execute arbitrary operating system commands with the full privileges of the packaging process.

Changes

  • packaging/checkPackageRuning.py

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@guanshengliang guanshengliang changed the base branch from develop to main May 6, 2026 10:57
@guanshengliang guanshengliang requested a review from feici02 as a code owner May 6, 2026 10:57
@zitsen
Copy link
Copy Markdown
Contributor

zitsen commented May 8, 2026

LGTM. Clean fix — input validation + list-form subprocess + secure tempdir. No new issues. Ship it.

@zitsen
Copy link
Copy Markdown
Contributor

zitsen commented May 8, 2026

Is this duplicated with #35276 ?

@orbisai0security
Copy link
Copy Markdown
Contributor Author

No, these are different vulnerabilities in the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants