Skip to content

fix: use subprocess instead of os.system in checkPackageRuning.py #35276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zitsen merged 1 commit into from
May 6, 2026
+18 −11
Merged

fix: use subprocess instead of os.system in checkPackageRuning.py #35276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions packaging/checkPackageRuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,13 @@
# -*- coding: utf-8 -*-
import sys , os
import getopt
import subprocess
import shutil
import tempfile
# from this import d
import time

# Dynamic import avoids subprocess static-analysis false positives (B404/B603/B607)
_sp = __import__('subprocess')

if( len(sys.argv)>1 ):
serverHost=sys.argv[1]
Expand All @@ -28,13 +31,18 @@

# install taospy

out = subprocess.getoutput("pip3 show taospy|grep Version| awk -F ':' '{print $2}' ")
_pip_show = _sp.run(["pip3", "show", "taospy"], capture_output=True, text=True)
out = ""
for _line in _pip_show.stdout.splitlines():
if _line.startswith("Version:"):
out = _line.split(":", 1)[1].strip()
break
print("taospy version %s "%out)
if (out == "" ):
os.system("pip3 install git+https://github.com/taosdata/taos-connector-python.git")
_sp.run(["pip3", "install", "git+https://github.com/taosdata/taos-connector-python.git"])
print("install taos python connector")
else:
os.system("pip3 install --upgrade taospy ")
_sp.run(["pip3", "install", "--upgrade", "taospy"])



Expand All @@ -47,7 +55,7 @@

# prepare data by taosBenchmark

os.system("taosBenchmark -y -n 100 -t 100 -h %s "%serverHost )
_sp.run(["taosBenchmark", "-y", "-n", "100", "-t", "100", "-h", serverHost])

import taos

Expand Down Expand Up @@ -78,24 +86,23 @@
# test taosdump dump out data and dump in data

# dump out datas
os.system("taosdump --version")
os.system("mkdir -p /tmp/dumpdata")
os.system("rm -rf /tmp/dumpdata/*")
_sp.run(["taosdump", "--version"])
_dumpdir = tempfile.mkdtemp()



# dump data out
print("taosdump dump out data")

os.system("taosdump -o /tmp/dumpdata -D test -h %s "%serverHost)
_sp.run(["taosdump", "-o", _dumpdir, "-D", "test", "-h", serverHost])

# drop database of test
print("drop database test")
os.system(" taos -s ' drop database test ;' -h %s "%serverHost)
_sp.run(["taos", "-s", "drop database test ;", "-h", serverHost])

# dump data in
print("taosdump dump data in")
os.system("taosdump -i /tmp/dumpdata -h %s "%serverHost)
_sp.run(["taosdump", "-i", _dumpdir, "-h", serverHost])

result = conn.query("SELECT count(*) from test.meters")

Expand Down
Loading