-
Notifications
You must be signed in to change notification settings - Fork 18
docs: rename PaymentId to MemoField #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MCozhusheck
wants to merge
1
commit into
tari-project:main
Choose a base branch
from
MCozhusheck:rfc-rename-payment-id-to-memo-field
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,7 +48,7 @@ technological merits of the potential system outlined herein. | |
|
|
||
| ## Goals | ||
|
|
||
| This document outlines the specification for Tari Address, which are encoded wallet addresses used to verify wallet addresses, features, and networks. | ||
| This document outlines the specification for Tari Address, which are encoded wallet addresses used to verify wallet addresses, features, and networks. | ||
| The address should have human-readable network and feature identification and contain all information required to send transactions to a wallet owning an address. | ||
|
|
||
| ## Related Requests for Comment | ||
|
|
@@ -88,9 +88,9 @@ Indicates the supported features of the wallet, such as interactive and one-side | |
| | one_sided only | 📟 | 01 | 2 | | ||
| | interactive only | 🌈 | 02 | 3 | | ||
| | onesided + interactive | 🌊 | 03 | 4 | | ||
| | one_sided + payment_id | 🐋 | 05 | 6 | | ||
| | interactive + payment_id | 🌙 | 06 | 7 | | ||
| | onesided + interactive + payment_id | 🤔 | 07 | 8 | | ||
| | one_sided + memo field | 🐋 | 05 | 6 | | ||
| | interactive + memo field | 🌙 | 06 | 7 | | ||
| | onesided + interactive + memo field | 🤔 | 07 | 8 | | ||
|
|
||
|
|
||
| #### Network | ||
|
|
@@ -109,17 +109,17 @@ Specifies the Tari network the wallet operates on, e.g., Esmeralda, Nextnet, etc | |
| The checksum is only included when encoding the address as bytes, hex, or emojis. For the checksum, the: [DammSum](https://github.com/cypherstack/dammsum) algorithm is employed, | ||
| with `k = 8` and `m = 32`, resulting in an 8-bit checksum. | ||
|
|
||
| #### Payment ID | ||
| Tari includes an optional encrypted bytes field with a max size of 256 bytes. This field allows you to store bytes that are encrypted on chain, on the UTXO. This can be used to track payments etc. When included into the Tari address, the sent UTXO will include this payment id. | ||
| #### Memo Field | ||
| Tari includes an optional encrypted bytes field with a max size of 256 bytes. This field allows you to store bytes that are encrypted on chain, on the UTXO. This can be used to track payments etc. When included into the Tari address, the sent UTXO will include this memo field. | ||
|
Comment on lines
+112
to
+113
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just |
||
|
|
||
| ### Encoding | ||
| ### Encoding | ||
| #### Bytes | ||
| When generating a byte representation of the wallet, the following format is used: | ||
| - [0]: Network encoded as u8 | ||
| - [1]: Raw u8 representing features | ||
| - [2..33]: Public view key encoded as u8 | ||
| - [34..65]: Public spend key encoded as u8 | ||
| - [66-N]: (Optional) Payment ID, encoded as u8 | ||
| - [66-N]: (Optional) Memo field, encoded as u8 | ||
| - [N+1]: DammSum checksum | ||
|
|
||
|
|
||
|
|
@@ -172,10 +172,11 @@ Each byte is encoded using the emoji listed at the corresponding index. | |
|
|
||
| ## Change Log | ||
|
|
||
| | Date | Change | Author | | ||
| |:-------------|:-------------------------|:--------------| | ||
| | 2024-05-31 | Initial stable | SWvHeerden | | ||
| | 2025-04-30 | Add payment ID | SWvHeerden | | ||
| | Date | Change | Author | | ||
| |:-----------|:------------------------------------|:------------| | ||
| | 2024-05-31 | Initial stable | SWvHeerden | | ||
| | 2025-04-30 | Add payment ID | SWvHeerden | | ||
| | 2025-06-21 | Rename Payment ID to Memo Field | MCozhusheck | | ||
|
|
||
| [Communication Node]: Glossary.md#communication-node | ||
| [Node ID]: Glossary.md#node-id | ||
| [Node ID]: Glossary.md#node-id | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest just calling it
memoinstead ofmemo fieldin this document.