-
Notifications
You must be signed in to change notification settings - Fork 6
feat: description prompt, default port fix, v0.13.0 #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -96,11 +96,12 @@ tari -e "wallet_daemon_url=http://localhost:12008/json_rpc" publish | |||||||||||||
| # tari.config.toml | ||||||||||||||
|
|
||||||||||||||
| [network] | ||||||||||||||
| wallet-daemon-jrpc-address = "http://127.0.0.1:9000/json_rpc" | ||||||||||||||
| wallet-daemon-jrpc-address = "http://127.0.0.1:5100/json_rpc" | ||||||||||||||
|
|
||||||||||||||
| # Optional | ||||||||||||||
| # default_account = "myaccount" | ||||||||||||||
| # default-account = "myaccount" | ||||||||||||||
| # metadata-server-url = "http://localhost:3000" | ||||||||||||||
| # template-address = "template_abc123..." | ||||||||||||||
|
Comment on lines
+102
to
+104
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The configuration keys in the documentation are inconsistent with the code. The
Suggested change
|
||||||||||||||
| ``` | ||||||||||||||
|
|
||||||||||||||
| ### Fields | ||||||||||||||
|
|
@@ -109,14 +110,15 @@ wallet-daemon-jrpc-address = "http://127.0.0.1:9000/json_rpc" | |||||||||||||
|
|
||||||||||||||
| | Field | Type | Default | Description | | ||||||||||||||
| |-------|------|---------|-------------| | ||||||||||||||
| | `wallet-daemon-jrpc-address` | URL | `http://127.0.0.1:9000/json_rpc` | Wallet daemon JSON-RPC endpoint | | ||||||||||||||
| | `wallet-daemon-jrpc-address` | URL | `http://127.0.0.1:5100/json_rpc` | Wallet daemon JSON-RPC endpoint | | ||||||||||||||
|
|
||||||||||||||
| #### Top-level optional fields | ||||||||||||||
|
|
||||||||||||||
| | Field | Type | Default | Description | | ||||||||||||||
| |-------|------|---------|-------------| | ||||||||||||||
| | `default_account` | String | None | Default wallet account | | ||||||||||||||
| | `default-account` | String | None | Default wallet account | | ||||||||||||||
| | `metadata-server-url` | URL | None | Metadata server URL | | ||||||||||||||
| | `template-address` | Address | None | Template address (saved automatically by `tari publish`) | | ||||||||||||||
|
Comment on lines
+119
to
+121
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These table entries should use underscores to match the field names in the
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| ### Managing Project Configuration | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line performs a redundant synchronous file read. The
handlefunction (the caller) has already read the contents ofCargo.tomlintocargo_toml_contentat line 65. Additionally, usingstd::fsin anasynccontext blocks the executor thread, which should be avoided. Consider passing the already-read content or a parsedDocumentMutto this function.