Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically removes all references to 'CMT Digital' across the website. The changes ensure that the site's content is up-to-date by eliminating an outdated partner from both visual displays and textual mentions, maintaining accuracy and relevance for users viewing the homepage and tokenomics information. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes references to CMT Digital from the website. The changes in TokenomicsPage.tsx are correct. However, in Track.tsx, while the image is removed, this has highlighted a couple of issues. The component uses a large, repetitive block of code to display images, which is hard to maintain. I've suggested refactoring this to be data-driven. More importantly, removing an image has likely broken the scrolling animation, which relies on a hardcoded value that probably needs to be updated. I've flagged this as a high-severity issue.
| <Image src={BlockchainCapital.src} alt="Blockchain Capital" /> | ||
| <Image src={ParisHilton.src} alt="Paris Hilton" /> | ||
| <Image src={CMTDigital.src} alt="CMT Digital" /> | ||
| <Image src={GEAZY.src} alt="G-Eazy" /> | ||
| <Image src={GMoney.src} alt="@gmoney" /> | ||
| <Image src={Loomdart.src} alt="@loomdart" /> | ||
| <Image src={LilWayne.src} alt="Lil Wayne" /> | ||
| <Image src={BlockchainCapital.src} alt="Blockchain Capital" /> | ||
| <Image src={ParisHilton.src} alt="Paris Hilton" /> | ||
| <Image src={CMTDigital.src} alt="CMT Digital" /> | ||
| <Image src={GEAZY.src} alt="G-Eazy" /> | ||
| <Image src={GMoney.src} alt="@gmoney" /> | ||
| <Image src={Loomdart.src} alt="@loomdart" /> | ||
| <Image src={LilWayne.src} alt="Lil Wayne" /> | ||
| <Image src={BlockchainCapital.src} alt="Blockchain Capital" /> | ||
| <Image src={ParisHilton.src} alt="Paris Hilton" /> | ||
| <Image src={CMTDigital.src} alt="CMT Digital" /> | ||
| <Image src={GEAZY.src} alt="G-Eazy" /> | ||
| <Image src={GMoney.src} alt="@gmoney" /> | ||
| <Image src={Loomdart.src} alt="@loomdart" /> | ||
| <Image src={LilWayne.src} alt="Lil Wayne" /> | ||
| <Image src={BlockchainCapital.src} alt="Blockchain Capital" /> | ||
| <Image src={ParisHilton.src} alt="Paris Hilton" /> | ||
| <Image src={CMTDigital.src} alt="CMT Digital" /> | ||
| <Image src={GEAZY.src} alt="G-Eazy" /> | ||
| <Image src={GMoney.src} alt="@gmoney" /> | ||
| <Image src={Loomdart.src} alt="@loomdart" /> | ||
| <Image src={LilWayne.src} alt="Lil Wayne" /> | ||
| <Image src={BlockchainCapital.src} alt="Blockchain Capital" /> | ||
| <Image src={ParisHilton.src} alt="Paris Hilton" /> | ||
| <Image src={CMTDigital.src} alt="CMT Digital" /> | ||
| <Image src={GEAZY.src} alt="G-Eazy" /> | ||
| <Image src={GMoney.src} alt="@gmoney" /> | ||
| <Image src={Loomdart.src} alt="@loomdart" /> | ||
| <Image src={LilWayne.src} alt="Lil Wayne" /> | ||
| <Image src={BlockchainCapital.src} alt="Blockchain Capital" /> | ||
| <Image src={ParisHilton.src} alt="Paris Hilton" /> | ||
| <Image src={CMTDigital.src} alt="CMT Digital" /> | ||
| <Image src={GEAZY.src} alt="G-Eazy" /> | ||
| <Image src={GMoney.src} alt="@gmoney" /> | ||
| <Image src={Loomdart.src} alt="@loomdart" /> |
There was a problem hiding this comment.
This block of <Image> components is highly repetitive, which makes it difficult to maintain. A better approach would be to define the image data in an array and then use .map() to render the components. This would make it easier to manage changes like the one in this PR.
Additionally, and more critically, the animation for this track has a hardcoded x: '-1691px' value (line 20). Since an image has been removed, the total width of the track has changed, and this hardcoded value is now likely incorrect. This will probably cause a visual glitch in the scrolling animation.
I suggest refactoring this component to be data-driven and to calculate the animation offset dynamically based on the content.
Example refactoring:
const images = [
{ src: BlockchainCapital.src, alt: 'Blockchain Capital' },
{ src: ParisHilton.src, alt: 'Paris Hilton' },
{ src: GEAZY.src, alt: 'G-Eazy' },
{ src: GMoney.src, alt: '@gmoney' },
{ src: Loomdart.src, alt: '@loomdart' },
{ src: LilWayne.src, alt: 'Lil Wayne' },
];
// You can create the repeated list like this
const repeatedImages = Array(6).fill(images).flat();
return (
// ...
<Track ...>
{repeatedImages.map((image, i) => <Image key={i} src={image.src} alt={image.alt} />)}
</Track>
// ...
);For the animation, you could use a ref on the track element to measure its width and adjust the animation properties accordingly.
Deploying tari-dot-com with
|
| Latest commit: |
20d99c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63eb9ef8.tari-dot-com.pages.dev |
| Branch Preview URL: | https://remove-cmt-digital.tari-dot-com.pages.dev |
1 participant
Removes all references to CMT Digital: