feat(worker): better handling of concurrency when fetching jobs #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [4.12.7](v4.12.6...v4.12.7) (2023-10-29) ### Performance Improvements * **redis-connection:** check redis version greater or equal than v6 only once ([#2252](#2252)) ([a09b15a](a09b15a))
…askforcesh/bullmq into feat/better-worker-concurrency
roggervalf
reviewed
Nov 18, 2023
|
|
||
| // Remove marker from active list. | ||
| await client.lrem(this.keys.active, 1, jobId); | ||
| if (this.blockUntil > 0) { |
There was a problem hiding this comment.
but could it be the case that when doing this logic, one delayed job with a lower delay value was added, so if we break here, blockUntil will have a higher value than expected, on the other hand if we continue, we will call moveToActive and get the most updated value if this case happens
There was a problem hiding this comment.
Hmm, if a delayed job with lower delay was added, then when calling BRPOPLPUSH we will move the new marker right? and update the timeout accordingly. We must block sometimes, otherwise we will enter in an endless loop calling moveToActive.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2023
# [4.14.0](v4.13.3...v4.14.0) (2023-11-18) ### Features * **worker:** better handling of concurrency when fetching jobs ([#2242](#2242)) ([d2e2035](d2e2035))
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles this issue: #2157