Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(redis-connection): check redis version greater or equal than v6 only once #2252

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

roggervalf
Copy link
Collaborator

No description provided.

Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I am not sure the test belongs to the description of the PR.

@roggervalf
Copy link
Collaborator Author

Looks good but I am not sure the test belongs to the description of the PR.

oh, that's unrelated, I was testing what happened when promoting a repeatable job, if it creates any duplication

@roggervalf roggervalf merged commit a09b15a into master Oct 29, 2023
10 checks passed
@roggervalf roggervalf deleted the perf-add-redis-capabilities branch October 29, 2023 06:35
github-actions bot pushed a commit that referenced this pull request Oct 29, 2023
## [4.12.7](v4.12.6...v4.12.7) (2023-10-29)

### Performance Improvements

* **redis-connection:** check redis version greater or equal than v6 only once ([#2252](#2252)) ([a09b15a](a09b15a))
roggervalf pushed a commit that referenced this pull request Oct 31, 2023
## [4.12.7](v4.12.6...v4.12.7) (2023-10-29)

### Performance Improvements

* **redis-connection:** check redis version greater or equal than v6 only once ([#2252](#2252)) ([a09b15a](a09b15a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants