Skip to content

Conversation

@Innominus
Copy link

@Innominus Innominus commented Jun 25, 2025

Code formatter has changed the kt code structure for the edited file. If it's not following guidelines/code format standards I'm happy to remove the extra whitespace changes.

Essentially it seems when writing the actions for an action group, it wasn't writing them the same way it was reading them. So it would add the actions but without an ID/title/input so they would show up blank.

Before:
image
After:
image

This is also what the code might look like when using the new builder syntax for ActionType and Action:

    let action_type = ActionType::builder("action-buttons")
        .actions(vec![
            Action::builder("visible-id", "Visible").foreground(true).build(),
            Action::builder("notification-action-id", "Notification Action Titles")
                .foreground(true)
                .build(),
        ])
        .build();

can register them; fix Android incorrectly storing actions in an action
group
@Innominus Innominus requested a review from a team as a code owner June 25, 2025 07:59
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Package Changes Through 3d9f99e

There are 15 changes which include dialog-js with minor, dialog with minor, log with minor, log-js with minor, localhost with patch, barcode-scanner with patch, barcode-scanner-js with patch, http with patch, http-js with patch, nfc with patch, nfc-js with patch, updater with minor, updater-js with minor, upload with minor, upload-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.38 2.0.39
api-example-js 2.0.34 2.0.35
barcode-scanner 2.4.2 2.4.3
barcode-scanner-js 2.4.2 2.4.3
dialog 2.4.2 2.5.0
dialog-js 2.4.2 2.5.0
http 2.5.4 2.5.5
http-js 2.5.4 2.5.5
localhost 2.3.1 2.3.2
log 2.7.1 2.8.0
log-js 2.7.1 2.8.0
nfc 2.3.3 2.3.4
nfc-js 2.3.3 2.3.4
updater 2.9.0 2.10.0
updater-js 2.9.0 2.10.0
upload 2.3.2 2.4.0
upload-js 2.3.2 2.4.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

ah merging v2 into this branch was dumb of me, i didn't see that your commit wasn't signed (please set that up for the future), i just made that harder so it'd be okay for me to skip it just this once :P

sorry for the long silence btw, i was waiting for the ci errors to be resolved and totally forgot about the PR in the meantime.

@FabianLars FabianLars added the status: waiting Waiting on author label Nov 24, 2025
@Innominus
Copy link
Author

Innominus commented Nov 24, 2025

@FabianLars hello! I did even worse and left this for 4 months, I'm so sorry haha. I'll give it a google and fix the signing and get this sorted. Does anything else beyond that need fixing?

Edit: ah the CI stuff is legit not just feature gates breaking things? I'll look into it. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[notification] Interaction buttons do not display text by registerActionTypes

2 participants