-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: Add total duration to the agenda #1706
base: main
Are you sure you want to change the base?
Conversation
Should we extract only the durations in the tables, or (which is what this PR is doing) also those in the bullet points? |
Github caches images very aggressively, and I'd think we want to avoid adding more external dependencies. |
Wdyt about an action that updates the time whenever there is a new commit on main? |
That seems like it'd create a ton of noise commits :-/ |
Are we worried about the number of commits in this repo? I certainly would prioritize having the total time readily available over minimizing the number commits, personally. |
In general yes, git commit history is worth keeping clean on every repo. I'm sure we can come up with a workaround - a github pages page that calculates it, for example, or a CI check that blocks additions that exceed the total time - that doesn't require spamming commits to the default branch. |
It seems like the |
I just updated the Deno script because the regexp was accidentally including 30m from "Short (≤30m) Timeboxed Discussions", and the PR preview was updated immediately. Caching is definitely not a problem :) |
@ryzokuken Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now
For alt text, something like "dynamically computed total of timeboxes on the agenda"? |
Alt text updated. Also I figured out how to change the URL to something nicer. |
Note that this will possibly show the wrong duration when looking at older versions of the agenda. |
how so? the year and month are part of the URL |
@ljharb Not other agenda documents. An older commit. |
Yeah this will always fetch the duration from main. That part of the agenda is mostly meant for us so it's probably fine, but I can add an explicit mention of this. Maybe one day with Shadow realm we'll be able to directly run JS in markdown :P |
Lets see if this works -- I'm not sure about how GitHub caches images.
Server code (using temporal and iterator helpers 😄): https://dash.deno.com/playground/tc39-agenda-time
If this works, then I can add it to the template.