Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Meta: add script to land PRs #1799

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Meta: add script to land PRs #1799

wants to merge 1 commit into from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Dec 2, 2019

This is a beginning attempt.

In the future I'll add more checks; this should ensure that all commit messages either have a valid prefix, or (if not the first commit), squash: or fixup: .

@ljharb ljharb added the meta label Dec 2, 2019
@ljharb ljharb force-pushed the commit-check branch 10 times, most recently from 2605f5a to b1b0ee7 Compare December 2, 2019 22:59
@ljharb
Copy link
Member Author

ljharb commented Dec 2, 2019

Failing: https://github.com/tc39/ecma262/pull/1799/checks?check_run_id=330098116
Passing: https://github.com/tc39/ecma262/pull/1799/checks?check_run_id=330132746
(altho the failing one no longer shows up; suffice to say it works)

@ljharb ljharb marked this pull request as ready for review December 2, 2019 23:01
ljharb added a commit to ljharb/ecma262 that referenced this pull request Dec 2, 2019
@ljharb
Meta: add action to check commit messages (tc39#1799)
032ed20
@bakkot
Copy link
Contributor

bakkot commented Dec 3, 2019 •
edited
Loading

I would strongly prefer we not do this.

Edit: on PRs, that is; I'm fine with enforcing this for master.

@ljharb
Copy link
Member Author

ljharb commented Dec 3, 2019

I'm confused as to why, but we can discuss it during the next editor call.

@bakkot bakkot added the editor call to be discussed in the next editor call label Dec 3, 2019
@syg syg removed the editor call to be discussed in the next editor call label Dec 11, 2019
@ljharb
Copy link
Member Author

ljharb commented Dec 11, 2019

As discussed; I'll repurpose this PR to contain a "land a PR" script, which will run these validations instead of doing it on each PR.

(My understanding of the objection, which I realize I agree with, is that PR status checks should only fail when the PR author can take action to correct them)

@ljharb ljharb self-assigned this Dec 11, 2019
@ljharb ljharb changed the title bad prefix: Meta: add action to check commit messages WIP: Meta: add script to land PRs Dec 11, 2019
@ljharb ljharb marked this pull request as draft April 8, 2020 20:46
@michaelficarra michaelficarra added editor call to be discussed in the next editor call and removed editor call to be discussed in the next editor call labels Oct 12, 2020
@ljharb
Copy link
Member Author

ljharb commented Oct 14, 2020

TODO: Document git procedure for merging here

@ljharb ljharb force-pushed the master branch 2 times, most recently from 1320e04 to 3d0c24c Compare June 29, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ljharb ljharb

Labels
meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljharb @bakkot @syg @michaelficarra