Editorial: Rework Module Namespace's [[Get]] method #2336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merely inlines Module Namespace's
[[Get]]
into its[[GetOwnProperty]]
method because:[[Get]]
doesn't (need to) terminate prototype chain traversal, unlike TypedArray's[[Get]]
, since module namespace object's prototype isnull
and it's non-extensible.[[HasProperty]]
or[[Delete]]
are subtly different from ordinary ones: they prevent from calling into[[GetOwnProperty]]
that may throw. We should avoid having methods that are totally equivalent to ordinary ones, like[[Get]]
, so they won't be accidentally ignored by implementors.[[Get]]
override, and continue performingOrdinaryGet
, which is preferred for simplicity / performance reasons.