Editorial: Set [[SourceText]] on classes before static blocks evaluate #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn’t seem editorial; maybe a normative bugfix? |
|
it hits a spec assertion... we generally consider that type of bugfix to be editorial right? |
|
The rule we've been using for bugfixes is that if the text is coherent but does not match committee intent it's Normative, whereas if it's outright incoherent it's Editorial. This is kind of in the middle, but since there's a failed assertion I'm fine calling it Editorial. |
spec.html
Outdated
| @@ -24755,6 +24755,7 @@ <h1> | |||
| Runtime Semantics: ClassDefinitionEvaluation ( | |||
| _classBinding_: unknown, | |||
| _className_: unknown, | |||
| _sourceText_: unknown, | |||
There was a problem hiding this comment.
Suggested change
| _sourceText_: unknown, | |
| _sourceText_: ECMAScript source text, |
spec.html
Outdated
| @@ -24917,15 +24919,15 @@ <h1>Runtime Semantics: Evaluation</h1> | |||
| </emu-note> | |||
| <emu-grammar>ClassExpression : `class` ClassTail</emu-grammar> | |||
| <emu-alg> | |||
| 1. Let _value_ be ? ClassDefinitionEvaluation of |ClassTail| with arguments *undefined* and *""*. | |||
| 1. Set _value_.[[SourceText]] to the source text matched by |ClassExpression|. | |||
| 1. Set _sourceText_ be the source text matched by |ClassExpression|. | |||
There was a problem hiding this comment.
Suggested change
| 1. Set _sourceText_ be the source text matched by |ClassExpression|. | |
| 1. Let _sourceText_ be the source text matched by |ClassExpression|. |
spec.html
Outdated
| 1. Return _value_. | ||
| </emu-alg> | ||
| <emu-grammar>ClassExpression : `class` BindingIdentifier ClassTail</emu-grammar> | ||
| <emu-alg> | ||
| 1. Let _className_ be StringValue of |BindingIdentifier|. | ||
| 1. Let _value_ be ? ClassDefinitionEvaluation of |ClassTail| with arguments _className_ and _className_. | ||
| 1. Set _value_.[[SourceText]] to the source text matched by |ClassExpression|. | ||
| 1. Set _sourceText_ be the source text matched by |ClassExpression|. |
There was a problem hiding this comment.
Suggested change
| 1. Set _sourceText_ be the source text matched by |ClassExpression|. | |
| 1. Let _sourceText_ be the source text matched by |ClassExpression|. |
spec.html
Outdated
| 1. Let _value_ be ? ClassDefinitionEvaluation of |ClassTail| with arguments *undefined* and *"default"*. | ||
| 1. Set _value_.[[SourceText]] to the source text matched by |ClassDeclaration|. | ||
| 1. Let _sourceText_ be the source text matched by |ClassDeclaration|. | ||
| 1. Let _value_ be ? ClassDefinitionEvaluation of |ClassTail| with arguments *undefined*, *"default"*, and _sourceText_. |
There was a problem hiding this comment.
We can return directly in these cases instead of introducing an alias.
Suggested change
| 1. Let _value_ be ? ClassDefinitionEvaluation of |ClassTail| with arguments *undefined*, *"default"*, and _sourceText_. | |
| 1. Return ? ClassDefinitionEvaluation of |ClassTail| with arguments *undefined*, *"default"*, and _sourceText_. |
devsnek
force-pushed
the
class-source-text
branch
from
6ab0dc2 to
2287414
Compare
devsnek
force-pushed
the
class-source-text
branch
from
2287414 to
0e851ce
Compare
|
This will fix #2669 (I think. Does this fix it for only static blocks, or both static blocks and static initializer expressions?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case:
class Foo { static { this.toString() } }This will require the
[[SourceText]]ofFooto be set.