Editorial: make single-implementation concrete methods into abstract operations #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Reading the commit titles, I wondered, "Why not |
syg
approved these changes
Jan 29, 2025
spec.html
Outdated
| @@ -19379,7 +19288,7 @@ <h1> | |||
| <emu-alg> | |||
| 1. Let _env_ be GetThisEnvironment(). | |||
| 1. Assert: _env_.HasSuperBinding() is *true*. | |||
There was a problem hiding this comment.
Please add an assertion in HasSuperBinding() that if it returns true, the environment record is a function environment record.
spec.html
Outdated
| @@ -19344,7 +19253,7 @@ <h1>Runtime Semantics: Evaluation</h1> | |||
| 1. If IsConstructor(_func_) is *false*, throw a *TypeError* exception. | |||
| 1. Let _result_ be ? Construct(_func_, _argList_, _newTarget_). | |||
| 1. Let _thisER_ be GetThisEnvironment(). | |||
| 1. Perform ? _thisER_.BindThisValue(_result_). | |||
There was a problem hiding this comment.
Similarly as the GetSuperBase comment, it'd be nice to have an assertion somewhere that _thisER_ is a function environment record.
bakkot
force-pushed
the
reduce-methods
branch
from
cb399ae to
d97ead5
Compare
michaelficarra
approved these changes
Jan 29, 2025
bakkot
added
the
ready to merge
bakkot
force-pushed
the
reduce-methods
branch
from
bd16c2f to
d72ef98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AOs are generally nicer for readers (and tooling).
I've left these where they were and just changed their type, but since each section is preceded by a sentence like
we should probably also either reword that sentence or move these somewhere else.
Commits can be reviewed individually but should land as a single commit.