Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: add RegExp.escape #3382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Normative: add RegExp.escape #3382

wants to merge 1 commit into from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 30, 2024

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. has test262 tests proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Jul 30, 2024
@ljharb ljharb requested a review from a team July 30, 2024 18:16
@ljharb ljharb mentioned this pull request Jul 30, 2024
Open
32 tasks
jmdyck
jmdyck requested changes Aug 28, 2024
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
1551bbf
@ljharb ljharb requested a review from jmdyck August 28, 2024 20:29
ljharb added a commit to tc39/proposal-regex-escaping that referenced this pull request Aug 28, 2024
@ljharb
[spec] feedback from tc39/ecma262#3382 (review)
44f4fb9
@michaelficarra michaelficarra mentioned this pull request Aug 28, 2024
Open
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
14df80b
@michaelficarra
Copy link
Member

deleted .github?! 😰

ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
1867fff
@ljharb
Copy link
Member Author

ljharb commented Aug 28, 2024

fixed; i have no idea how that happened

ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
6110ce5
jmdyck
jmdyck requested changes Aug 29, 2024
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 29, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
270847a
@jmdyck
Copy link
Collaborator

jmdyck commented Aug 29, 2024

Passes my checks now.

ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 21, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
d8495c3
jmdyck
jmdyck reviewed Oct 22, 2024
View reviewed changes
spec.html Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdyck jmdyck jmdyck approved these changes

@michaelficarra michaelficarra michaelficarra left review comments

Assignees
No one assigned
Labels
has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @michaelficarra @jmdyck