Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add baseline with inline assets & fix issues #584

Merged
merged 3 commits into from
Mar 22, 2024
Merged

add baseline with inline assets & fix issues #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f07af9
add baseline with inline assets
bakkot Mar 22, 2024
c71581d
supress warning for invalid css
bakkot Mar 22, 2024
1ec7e2a
include img directory in package
bakkot Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"/lib",
"/js",
"/css",
"/img",
"/fonts",
"/boilerplate",
"/entities-processed.json"
Expand Down
1 change: 1 addition & 0 deletions src/Spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,7 @@ ${await utils.readFile(path.join(__dirname, '../js/multipage.js'))}

private async buildAssets(jsContents: string, jsSha: string) {
if (this.assets.type === 'none') return;
this.log('Building assets...');

// check for very old manual 'ecmarkup.js'/'ecmarkup.css'
const oldEles = this.doc.querySelectorAll(
Expand Down
6 changes: 5 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ export function emdTextNode(spec: Spec, node: Text, namespace: string) {

/*@internal*/
export function htmlToDom(html: string) {
return new jsdom.JSDOM(html, { includeNodeLocations: true });
const virtualConsole = new jsdom.VirtualConsole();
virtualConsole.on('error', () => {
// Suppress warnings from e.g. CSS features not supported by JSDOM
});
return new jsdom.JSDOM(html, { includeNodeLocations: true, virtualConsole });
}

/*@internal*/
Expand Down
Loading
Loading