Create feedback.md #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7 (just a rephrasing of the content filed there)
ljharb
reviewed
Jan 2, 2019
Co-Authored-By: littledan <[email protected]>
ljharb
approved these changes
Jan 3, 2019
rkirsling
reviewed
Jan 3, 2019
| - We're all coming from different perspectives and have partial knowledge of the universe. Give your feedback from wherever you're at. For example, there is no need to dress up feedback in formal language if your thought process doesn't correspond to that. | ||
| - Whenever possible, give feedback ahead of a TC39 meeting in issues on the GitHub repository for the proposal. | ||
| - Search for existing issues which cover a topic before posting a new topic. | ||
| - It's helpful to give positive feedback, or feedback agreeing with a previous critique, as well as new points of critique. |
There was a problem hiding this comment.
Seems like some of these would do well with examples of "instead of something like A, it would be more effective to say something like B". Surely not necessary for this PR, but could be a nice way to flesh out the document.
There was a problem hiding this comment.
Oops, since this is merged, want to file a tracking issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7 (just a rephrasing of the content filed there)