Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HostGetSupportedAssertions() and only give hosts supported assertions. #103

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

dandclark
Copy link
Collaborator

@dandclark dandclark commented Nov 10, 2020

Add a new host operation for hosts to specify the assertion keys that they support. Only supported assertions are returned to the host. This ensures that unsupported assertions will be handled in the same way (ignored) across all hosts.

Resolves #102.

Copy link
Member

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but also, I could see us specifying this declaratively. Please edit the slides of the status update to mention this potential change as well; I think we'll need consensus from the committee about this change.

…pport. Only supported assertions are provided to the host.
@dandclark dandclark force-pushed the dandclark/get-host-supported-assertions branch from 7949cc8 to 9cdc358 Compare November 16, 2020 22:56
@xtuc
Copy link
Member

xtuc commented Nov 19, 2020

This change has reached consensus in the last TC39 meeting (November 2020)

@dandclark dandclark merged commit 61c13d4 into master Nov 25, 2020
@dandclark dandclark deleted the dandclark/get-host-supported-assertions branch November 25, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are unknown assertions a host decision?
3 participants