Normative: Reject too large dates in ToTemporalMonthDay #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 21 21
Lines 9928 9929 +1
Branches 1801 1801
=======================================
+ Hits 9545 9546 +1
Misses 336 336
Partials 47 47 ☔ View full report in Codecov by Sentry. |
|
Thanks. We'll discuss this in the next champions meeting. |
ptomato
requested changes
Jan 14, 2025
ptomato
pushed a commit
that referenced
this pull request
Feb 5, 2025
…earMonth The call to `CalendarYearMonthFromFields` will already reject too large dates, but adding an explicit step makes it more obvious that `ISODateToFields` doesn't require support for mapping large ISO dates to calendar dates. And it also aligns `ToTemporalYearMonth` with `ToTemporalMonthDay` after #3054.
Ms2ger
pushed a commit
that referenced
this pull request
Feb 5, 2025
…earMonth The call to `CalendarYearMonthFromFields` will already reject too large dates, but adding an explicit step makes it more obvious that `ISODateToFields` doesn't require support for mapping large ISO dates to calendar dates. And it also aligns `ToTemporalYearMonth` with `ToTemporalMonthDay` after #3054.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 5, 2025
…y strings This adds coverage for the normative change in tc39/proposal-temporal#3054, which specifies that implementations must throw on out-of-range dates in RFC 9557 strings for non-ISO calendars.
|
Tests are in tc39/test262#4389. |
ptomato
force-pushed
the
to-month-day-limit
branch
from
3ce9a20 to
19f17f6
Compare
ptomato
approved these changes
Feb 5, 2025
|
Draft until approved in TC39. |
|
Approved in the TC39 plenary of 2025-02-18. I'll pull in the test262 update before merging this. |
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 22, 2025
…y strings This adds coverage for the normative change in tc39/proposal-temporal#3054, which specifies that implementations must throw on out-of-range dates in RFC 9557 strings for non-ISO calendars.
ptomato
added a commit
to tc39/test262
that referenced
this pull request
Feb 22, 2025
…y strings This adds coverage for the normative change in tc39/proposal-temporal#3054, which specifies that implementations must throw on out-of-range dates in RFC 9557 strings for non-ISO calendars.
ptomato
force-pushed
the
to-month-day-limit
branch
from
19f17f6 to
a143609
Compare
Implements the normative change from the previous commit in the reference code.
ptomato
force-pushed
the
to-month-day-limit
branch
from
a143609 to
1cfbd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3008 / #3002 to reject too large dates.