Editorial: Small batch of changes #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3091 +/- ##
==========================================
- Coverage 96.14% 96.05% -0.10%
==========================================
Files 21 21
Lines 9929 9951 +22
Branches 1801 1802 +1
==========================================
+ Hits 9546 9558 +12
- Misses 336 346 +10
Partials 47 47 ☔ View full report in Codecov by Sentry. |
The strategy of caching the output of DTF resolvedOptions() failed in the case of hour12/hourCycle, because those options are silently dropped if the chosen format does not include an hour component. Manually add them to the cached resolvedOptions object if the user included them. See: #3065
https://tc39.es/proposal-temporal/#sec-temporal-parsetemporalcalendarstring ParseTemporalCalendarString specifies to try to parse the string as TemporalDateTimeString[+Zoned], TemporalDateTimeString[~Zoned], TemporalInstantString, TemporalTimeString, TemporalMonthDayString, and TemporalYearMonthString consecutively until one succeeds. I always thought TemporalTimeString would be handled by ParseISODateTime in the polyfill, but it seems I was wrong about that. See: #3090
gibson042
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test262 tests