withYear() object argument #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 17 17
Lines 4013 4019 +6
Branches 596 599 +3
=======================================
+ Hits 3914 3920 +6
Misses 97 97
Partials 2 2
Continue to review full report at Codecov.
|
ryzokuken
approved these changes
May 12, 2020
| if (typeof item === 'object') { | ||
| ({ year } = ES.ToRecord(item, [['year']])); | ||
| } else { | ||
| year = ES.ToInteger(item); |
There was a problem hiding this comment.
We weren't calling ToInteger before? 😳
| The following steps are taken: | ||
| </p> | ||
| <emu-alg> | ||
| 1. Let _monthDay_ be the *this* value. | ||
| 1. Perform ? RequireInternalSlot(_monthDay_, [[InitializedTemporalMonthDay]]). | ||
| 1. Let _y_ be ? ToInteger(_year_). |
There was a problem hiding this comment.
Idk why the polyfill wasn't doing this 😅
sffc
reviewed
May 12, 2020
This argument is necessary when you have a calendar where the year is
not enough information to convert from MonthDay to Date. e.g.:
const monthDay = Temporal.MonthDay.from({ month: 4, day: 1, calendar: 'japanese' });
const date = monthDay.toDate({ year: 18, era: "heisei" });
The existing API should continue to work unchanged, although there is
one behavioural change. An object with valueOf() returning a number will
no longer act as a number argument, because it will instead go down the
object argument code path.
See: #490
Summary of the discussion in: - #490 (comment) - #490 (comment) Closes: #490
ptomato
force-pushed
the
490-withyear-object-argument
branch
from
6a4f8ff to
cff3a54
Compare
sffc
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #490