Added HostEnsureCanCompileStrings and evalable #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would provide github.com/wicg/trusted-types what it needs to provide source-to-sink security for code strings.
ljharb
approved these changes
Apr 3, 2019
| | [Function bind syntax][bind-syntax] | Kevin Smith | Brian Terlson<br />Matthew Podwysocki | [March 2015][bind-notes] | | ||
| | [Function expression decorators][func-expr-decorators] | Igor Minar | Igor Minar | | | ||
| | [HostEnsureCanCompileStrings passthrough][heccspt] | Mike Samuel | Mike Samuel | | |
There was a problem hiding this comment.
This one seems like a needs consensus PR more than a proposal to me.
There was a problem hiding this comment.
Ok. So is the process:
- rework it as a PR against tc39/ecma262/spec.html,
- attach the "needs_consensus" label,
- schedule 15 minutes under "9. Web compatibility issues / Needs Consensus PRs" on the agenda
There was a problem hiding this comment.
It's certainly up to you if you want to bring it as a proposal - it's possible that some delegates will insist it be one, but it's also possible that delegates will consider it more of a PR.
There was a problem hiding this comment.
In PR form: tc39/ecma262#1498
There was a problem hiding this comment.
@ljharb Thanks for explaining. I'll go with PR for now, and have the proposal ready if it's clear that's the way the committee wants to handle it.
Will do. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These would provide github.com/wicg/trusted-types what it needs to provide source-to-sink security for code strings.