Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise.prototype.finally creates thenFinally and catchFinally in onFinally's realm #2910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Promise.prototype.finally creates thenFinally and catchFinally in onFinally's realm #2910

wants to merge 1 commit into from

Conversation

arai-a
Copy link
Contributor

@arai-a arai-a commented Nov 24, 2020

@arai-a arai-a mentioned this pull request Nov 24, 2020
Open
@rwaldron rwaldron added the awaiting consensus This needs committee consensus before it can be eligible to be merged. label Nov 25, 2020
rwaldron
rwaldron previously approved these changes Nov 25, 2020
View reviewed changes
@rwaldron rwaldron requested a review from jugglinmike January 18, 2021 17:53
jugglinmike
jugglinmike reviewed Nov 12, 2021
View reviewed changes
Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test appears to correctly assert the proposed semantics, so it should be okay to merge when the change to ECMA262 is accepted.

I've left some thoughts about how the precision and readability could be improved.

@jridgewell jridgewell mentioned this pull request Dec 15, 2021
Open
@arai-a arai-a requested a review from a team as a code owner August 4, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugglinmike jugglinmike jugglinmike left review comments

@rwaldron rwaldron rwaldron left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting consensus This needs committee consensus before it can be eligible to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arai-a @rwaldron @jugglinmike