Builtin boilerplate tests from PR #3866#4236
Merged
Conversation
ptomato
approved these changes
Sep 23, 2024
test/built-ins/AsyncDisposableStack/prototype/Symbol.asyncDispose.js
Outdated
Show resolved
Hide resolved
test/built-ins/AsyncDisposableStack/prototype/disposed/getter.js
Outdated
Show resolved
Hide resolved
Comment on lines
+16
to
+19
| assert.sameValue(DisposableStack.prototype[Symbol.dispose], DisposableStack.prototype.dispose); | ||
| verifyNotEnumerable(DisposableStack.prototype, Symbol.dispose); | ||
| verifyWritable(DisposableStack.prototype, Symbol.dispose); | ||
| verifyConfigurable(DisposableStack.prototype, Symbol.dispose); |
Contributor
There was a problem hiding this comment.
Same comment as above, use verifyProperty
Comment on lines
+29
to
+30
| verifyNotEnumerable(DisposableStack.prototype, 'disposed'); | ||
| verifyConfigurable(DisposableStack.prototype, 'disposed'); |
Contributor
There was a problem hiding this comment.
Same comment as above, use verifyProperty
Ms2ger
approved these changes
Sep 24, 2024
Includes some proto-from-ctor-realm.js tests that look like standard tests for prototypes.
Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
Ms2ger
force-pushed
the
ERM-boilerplates-builtin
branch
from
7696475 to
8864659
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits some of the boilerplate tests from PR #3866 to make reviewing all those files a little easier.
Includes some proto-from-ctor-realm.js tests that look like standard tests for prototypes.