Conversation
ptomato
approved these changes
Jan 31, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks very much. This is about the right size to get done quickly and it's very helpful that the tests you've split out are similar to each other.
ljharb
added a commit
to es-shims/DisposableStack
that referenced
this pull request
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello test262 maintainers!
Based on the instructions in #3866 (comment) have split out this pr it includes some of the simple tests on the (Async)DisposableStack prototypes and constructor
Do let me know if this looks ok I shall follow this up with more split out prs sorry for the delay
Thank you!