Conversation
ptomato
reviewed
May 29, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I learned a lot reviewing this PR. Thanks!
test/language/statements/await-using/syntax/await-using-allowed-at-top-level-of-module.js
Outdated
Show resolved
Hide resolved
...t-using/syntax/block-scope-syntax-await-using-declarations-mixed-with-without-initializer.js
Show resolved
Hide resolved
...language/statements/await-using/syntax/await-using-invalid-assignment-next-expression-for.js
Show resolved
Hide resolved
...nguage/statements/await-using/syntax/await-using-invalid-assignment-statement-body-for-of.js
Outdated
Show resolved
Hide resolved
rbuckton
force-pushed
the
explicit-resource-management-await-using-syntax
branch
from
1c7f1de to
bd747be
Compare
ptomato
approved these changes
Nov 4, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I'm assuming the ReferenceError was the only thing that changed, I reviewed the rest a while ago.
ptomato
force-pushed
the
explicit-resource-management-await-using-syntax
branch
from
799cd44 to
8938fb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to make review more manageable, this extracts the remaining tests specific to
await usingstatement syntax from #3866