Add RegExp source escaping tests for remaining LineTerminators (CR, LS, PS)#4958
Open
Add RegExp source escaping tests for remaining LineTerminators (CR, LS, PS)#4958
Conversation
…S, PS) Covers the three LineTerminators not yet tested in canonical form: - U+000D CARRIAGE RETURN - U+2028 LINE SEPARATOR - U+2029 PARAGRAPH SEPARATOR Each test verifies that EscapeRegExpPattern produces a source value that round-trips through eval to a behaviorally equivalent RegExp, per sec-get-regexp.prototype.source. Addresses tc39#97. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds canonical roundtrip tests for the three LineTerminators not yet covered in test/built-ins/RegExp/prototype/source/:
Each test follows the same pattern as the existing value-line-terminator.js: construct a RegExp containing the character, round-trip its .source through eval, and assert behavioral equivalence.
Closes #97.