Temporal: Remove string parsing tests from staging#4959
Merged
Conversation
Ms2ger
approved these changes
Mar 2, 2026
I've replaced these string parsing tests with more thorough snapshotting tests in proposal-temporal: tc39/proposal-temporal#3286 I'll run those against each implementation to find out any remaining implementation divergences, and add more targeted tests to test262 covering any that I find. But for the time being, it doesn't make sense to keep these here. Supersedes tc39#4286.
Ms2ger
force-pushed
the
rm-staging-temporal-regex-tests
branch
from
b58515b to
d877e7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've replaced these string parsing tests with more thorough snapshotting tests in proposal-temporal:
tc39/proposal-temporal#3286
I'll run those against each implementation to find out any remaining implementation divergences, and add more targeted tests to test262 covering any that I find. But for the time being, it doesn't make sense to keep these here.
Closes #4286.