Skip to content

[Temporal] Fix time zones in no-fractional-minutes-hours tests #5001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptomato merged 1 commit into from
Mar 20, 2026
+15 −15
Merged

[Temporal] Fix time zones in no-fractional-minutes-hours tests #5001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/built-ins/Temporal/Instant/compare/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ features: [Temporal]
---*/

const invalidStrings = [
["2025-04-03T05:07.123[CET]", "Fractional minutes"],
["2025-04-03T12.5[CET]", "Fractional hours"],
["2025-04-03T05:07.123[UTC]", "Fractional minutes"],
["2025-04-03T12.5[UTC]", "Fractional hours"],
];

for (const [arg, description] of invalidStrings) {
Expand Down
4 changes: 2 additions & 2 deletions test/built-ins/Temporal/Instant/from/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ features: [Temporal]
---*/

const invalidStrings = [
["2025-04-03T05:07.123[CET]", "Fractional minutes"],
["2025-04-03T12.5[CET]", "Fractional hours"],
["2025-04-03T05:07.123[UTC]", "Fractional minutes"],
["2025-04-03T12.5[UTC]", "Fractional hours"],
];

for (const [arg, description] of invalidStrings) {
Expand Down
4 changes: 2 additions & 2 deletions test/built-ins/Temporal/Instant/prototype/equals/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ features: [Temporal]
const instance = new Temporal.Instant(0n)

const invalidStrings = [
["2025-04-03T05:07.123[CET]", "Fractional minutes"],
["2025-04-03T12.5[CET]", "Fractional hours"],
["2025-04-03T05:07.123[UTC]", "Fractional minutes"],
["2025-04-03T12.5[UTC]", "Fractional hours"],
];

for (const [arg, description] of invalidStrings) {
Expand Down
4 changes: 2 additions & 2 deletions test/built-ins/Temporal/Instant/prototype/since/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ features: [Temporal]
const instance = new Temporal.Instant(0n)

const invalidStrings = [
["2025-04-03T05:07.123[CET]", "Fractional minutes"],
["2025-04-03T12.5[CET]", "Fractional hours"],
["2025-04-03T05:07.123[UTC]", "Fractional minutes"],
["2025-04-03T12.5[UTC]", "Fractional hours"],
];

for (const [arg, description] of invalidStrings) {
Expand Down
4 changes: 2 additions & 2 deletions test/built-ins/Temporal/Instant/prototype/until/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ features: [Temporal]
const instance = new Temporal.Instant(0n)

const invalidStrings = [
["2025-04-03T05:07.123[CET]", "Fractional minutes"],
["2025-04-03T12.5[CET]", "Fractional hours"],
["2025-04-03T05:07.123[UTC]", "Fractional minutes"],
["2025-04-03T12.5[UTC]", "Fractional hours"],
];

for (const [arg, description] of invalidStrings) {
Expand Down
4 changes: 2 additions & 2 deletions test/built-ins/Temporal/ZonedDateTime/compare/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ const invalidStrings = [
for (const [arg, description] of invalidStrings) {
assert.throws(
RangeError,
() => Temporal.ZonedDateTime.compare(arg, new Temporal.ZonedDateTime(0n, "CET")),
() => Temporal.ZonedDateTime.compare(arg, new Temporal.ZonedDateTime(0n, "UTC")),
`${description} not allowed in time string (first argument)`
);
assert.throws(
RangeError,
() => Temporal.ZonedDateTime.compare(new Temporal.ZonedDateTime(0n, "CET"), arg),
() => Temporal.ZonedDateTime.compare(new Temporal.ZonedDateTime(0n, "UTC"), arg),
`${description} not allowed in time string (second argument)`
);
}
2 changes: 1 addition & 1 deletion test/built-ins/Temporal/ZonedDateTime/prototype/equals/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ description: Fractional minutes or hours in time string should throw RangeError
features: [Temporal]
---*/

const instance = new Temporal.ZonedDateTime(0n, "CET")
const instance = new Temporal.ZonedDateTime(0n, "UTC")

const invalidStrings = [
["2025-04-03T05:07.123", "Fractional minutes"],
Expand Down
2 changes: 1 addition & 1 deletion test/built-ins/Temporal/ZonedDateTime/prototype/since/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ description: Fractional minutes or hours in time string should throw RangeError
features: [Temporal]
---*/

const instance = new Temporal.ZonedDateTime(0n, "CET")
const instance = new Temporal.ZonedDateTime(0n, "UTC")

const invalidStrings = [
["2025-04-03T05:07.123", "Fractional minutes"],
Expand Down
2 changes: 1 addition & 1 deletion test/built-ins/Temporal/ZonedDateTime/prototype/until/no-fractional-minutes-hours.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ description: Fractional minutes or hours in time string should throw RangeError
features: [Temporal]
---*/

const instance = new Temporal.ZonedDateTime(0n, "CET")
const instance = new Temporal.ZonedDateTime(0n, "UTC")

const invalidStrings = [
["2025-04-03T05:07.123", "Fractional minutes"],
Expand Down
Loading