Downgrade ES6+ syntax in a couple of key harness files#5006
Open
Downgrade ES6+ syntax in a couple of key harness files#5006
Conversation
Replace template literals with equivalent string concatenation in assert.js and remove the trailing argument comma in propertyHelper.js. This makes the harness ES5-friendlier and allows nearly a third of the tests to pass on old ES5 engines from a baseline of ~8.7% of all negative cases - assert.js is a key blocker.
Member
Author
|
I'm proposing only to change these two high-impact places. There's a lot of more of ES6 in the harness but the marginal effect of changing anything else is pretty small. |
Ms2ger
approved these changes
Mar 26, 2026
Contributor
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
I don't love the direction, but I think the changes here are acceptable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace template literals with equivalent string concatenation in assert.js and remove the trailing argument comma in propertyHelper.js.
This makes the harness ES5-friendlier and allows nearly a third of the tests to pass on old ES5 engines from a baseline of ~8.7% of all negative cases - assert.js is a key blocker.
Improvement in pass rate in my testing: