🐛✅ support headings in list items #363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommonMark specifically [allows headings in list items](https://spec.commonmark.org/0.31.2/#example-300).
dudeofawesome
force-pushed
the
fix/heading-in-list
branch
from
f945da4 to
10363f5
Compare
|
This will be in conflict with: |
|
Hmm, looks like it should be very easy to merge the 2. My primary changes here are in identifying the section titles, while the other PR is looking at the links themselves. |
|
@dudeofawesome #328 has been merged. If you can update this branch and mark it ready for review when done we can have a look at it. |
|
|
This pull request has been marked as stale because it has been open 60 days with no activity. It will be closed in 30 days unless the stale label is removed or someone adds a comment. |
|
This pull request was closed because it has been marked as stale for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommonMark specifically allows headings in list items.