BUGFIX Load all tours on start already #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tour may not start and throw an error instead:
"startTour: SomeTourName tour not found"
This is because the tour is not loaded/initialized yet.
with this fix all available tours are always loaded.
* Pro: Tours working again.
* Con: Very negative perfomance impact (one request &
data handling for each tour)
→ his fix should be replaced again soon
pixelbrackets
changed the title
|
Please note: As said in the commit note, this may not be the final solution for the issue. It helped solve the problem #18 in my case, but fires requests for all available tour upon starting the backend. This is a perfomance issue and therefor should be replaced with a better solution sometime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the current tour is undefinied, then dont load it.
If the current tour is defined and not loaded yet, then load it.
refs #18