⚡ Bolt: Optimize DenseLayer backward pass by taking ownership of cached inputs - #168
⚡ Bolt: Optimize DenseLayer backward pass by taking ownership of cached inputs#168teerthsharma wants to merge 1 commit into
Conversation
…ed inputs Co-authored-by: teerthsharma <78080953+teerthsharma@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
.as_ref().expect(...).clone()with.take().expect(...)forlast_zandlast_inputinDenseLayer::backward.🎯 Why: Cloning these tensors during the backward pass triggered unnecessary heap allocations for tensor metadata (shape/strides).
last_zandlast_inputare only needed once per backward pass, so ownership can be safely taken.📊 Impact: Eliminates two metadata heap allocations and Rc increments per backward pass per layer.
🔬 Measurement: Verified by running the core test suite.
PR created automatically by Jules for task 3099305425076104399 started by @teerthsharma