Skip to content

⚡ Bolt: Optimize DenseLayer backward pass by taking ownership of cached inputs - #168

Open
teerthsharma wants to merge 1 commit into
masterfrom
bolt-dense-layer-backward-opt-3099305425076104399
Open

⚡ Bolt: Optimize DenseLayer backward pass by taking ownership of cached inputs#168
teerthsharma wants to merge 1 commit into
masterfrom
bolt-dense-layer-backward-opt-3099305425076104399

Conversation

@teerthsharma

Copy link
Copy Markdown
Owner

💡 What: Replaced .as_ref().expect(...).clone() with .take().expect(...) for last_z and last_input in DenseLayer::backward.
🎯 Why: Cloning these tensors during the backward pass triggered unnecessary heap allocations for tensor metadata (shape/strides). last_z and last_input are only needed once per backward pass, so ownership can be safely taken.
📊 Impact: Eliminates two metadata heap allocations and Rc increments per backward pass per layer.
🔬 Measurement: Verified by running the core test suite.


PR created automatically by Jules for task 3099305425076104399 started by @teerthsharma

…ed inputs

Co-authored-by: teerthsharma <78080953+teerthsharma@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant