Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add stepaction as a valid kind in the hub resolver #8635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add stepaction as a valid kind in the hub resolver #8635

wants to merge 1 commit into from

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Mar 11, 2025 •
edited
Loading

Changes

fixes #8634

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

the hub resolver now validates StepActions as a valid kind

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 11, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign imjasonh after the PR has been reviewed.
You can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2025
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Mar 11, 2025
@waveywaves
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2025
@waveywaves
fix: add stepaction as a valid kind in the hub resolver
5bc1e64 
The hub resolver should consider StepAction as a valid kind.
This change ensures that the controller considers a stepaction as a valid kind
resolving through a hub resolver.

test: validate step actions in hub resolver
@waveywaves waveywaves force-pushed the step-action-artifact-hub-resolution branch from 5c8232f to 5bc1e64 Compare March 11, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop Awaiting requested review from jerop

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: stepaction with artifacthub resolver fails on validation
2 participants
@waveywaves @tekton-robot