chore: Break Gitea e2e tests down - #2889
Conversation
KMI1011
changed the title
theakshaypant
left a comment
theakshaypant
left a comment
There was a problem hiding this comment.
Hey @KMI1011 ! Please rebase and resolve the conflicts.
8ba8653 to
44126eb
Compare
|
/ptal @theakshaypant |
|
there is other existing gitea test should we merge them in that breakout? |
There was a problem hiding this comment.
Leaving just successRegexp here feels a bit odd to me. We can perhaps move it to test/pkg/gitea/, WDYT?
There was a problem hiding this comment.
That would probably be better, I can get to doing that, I'll move it to test.go
|
please organise your commits and remove those git trailers that is added by others |
From what I can tell I think it'd depend (?) Like if you think for ex, specifically |
e6872a2 to
eaef909
Compare
theakshaypant
left a comment
theakshaypant
left a comment
There was a problem hiding this comment.
Tests are broken, please refer the failed CI.
eaef909 to
9e16b38
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
=======================================
Coverage 68.77% 68.77%
=======================================
Files 197 197
Lines 16866 16866
=======================================
Hits 11599 11599
Misses 4405 4405
Partials 862 862
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@KMI1011 I think you did this from an old branch because we've removed repo.Status in a recent PR but your still using that old code |
9e16b38 to
d22b3c4
Compare
|
If you're available /ptal @zakisk, I think I caught the issue you were referring to |
| // It will create a new branch and push a new Pull Request with a PipelineRun of | ||
| // the same name of the first PR and make sure PipelineRun of the same name only | ||
| // acts on the same Pull Request and not on the one of the others. | ||
| func TestGiteaConfigCancelInProgress(t *testing.T) { |
There was a problem hiding this comment.
create one another file gitea_pull_request_test.go put some unique kind of test e.g. cancel-in-progress tests TestGiteaConfigCancelInProgress TestGiteaConfigCancelInProgressAfterPRClosed TestGiteaPullRequestPrivateRepository
d22b3c4 to
39e46cb
Compare
|
pre-commit is local thing and your commit message contains: can you please also remove that |
39e46cb to
3f6f2b6
Compare
59dbbcc to
1c5b0f8
Compare
Break down the monolithic Gitea E2E test file (42 tests) into 8 focused files grouped by concern: remote tasks, concurrency, YAML errors, error snippets, push events, CLI, event filtering, and provenance. No test behavior changes. Fixes tektoncd#2828
1c5b0f8 to
06cb53f
Compare
|
/ok-to-test |
theakshaypant
left a comment
theakshaypant
left a comment
There was a problem hiding this comment.
I see the PR has been merged but I would advise you to create a follow up for this.
| // TestGiteaConfigCancelInProgress will test the pipelinerun annotation | ||
| // `pipelinesascode.tekton.dev/cancel-in-progress: "true", it will first start | ||
| // one Pull Request which will run a PipelineRun and then send a /retest which | ||
| // should cancel the in progress one. | ||
| // It will create a new branch and push a new Pull Request with a PipelineRun of | ||
| // the same name of the first PR and make sure PipelineRun of the same name only | ||
| // acts on the same Pull Request and not on the one of the others. |
There was a problem hiding this comment.
Misplaced comment for TestGiteaConfigCancelInProgress
6 participants
📝 Description of the Change
Break down the monolithic Gitea E2E test file (42 tests) into 8 focused files grouped by concern: remote tasks, concurrency, YAML errors, error snippets, push events, CLI, event filtering, and provenance. No test behavior changes.
🔗 Linked GitHub Issue
Fixes #2828
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
(General advice/testing usage)
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.