Skip to content

Issue 46 - Return 0 if sub would underflow #80

Open
ethereumdegen wants to merge 1 commit intomerge-train-r5from
fix/issue-46
Open

Issue 46 - Return 0 if sub would underflow #80
ethereumdegen wants to merge 1 commit intomerge-train-r5from
fix/issue-46

Conversation

@ethereumdegen
Copy link
Collaborator

No description provided.

@ethereumdegen
Copy link
Collaborator Author

hash:

Fixed the underflow issue. But the excess repaid amount will not be withdrawable by the other lenders. This should be ok though if the lenders are only being guarenteed their deposited amount. One thing to note is that this amount will still be borrowable. And if liquidation of it occurs and goes negative, PoolTotalEstimatedValue can go to negative (underflow is handled) and this amount would be taken from the newer depositors rather than the actually available extra amount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant